K 10
svn:author
V 7
mibsoft
K 8
svn:date
V 27
1998-02-26T13:54:44.000000Z
K 7
svn:log
V 1633
|From:             Richard Michael Todd <rmtodd@mailhost.ecn.ou.edu>
|
|Found what seem to be a couple of nasty bugs in makehistory.
|
|1)  In the function DoNewsgroup (which looks at the files in a given
|    (traditional-format) news spool dir), the current file name never gets
|    appended to the 'buff' buffer that is supposed to hold the full path.
|    This causes, e.g. the '-b' option to attempt to remove files with
|    completely bogus filenames.
|
|2)  In the function DoMemArt(), there's code that handles article headers
|    that are listed in ARTfields, and code that handles article headers that
|    are listed in the Missfields array.  The code for the former case looks
|    for a \r\n to terminate the header, and the resulting string is set to
|    be the header string sans the \r\n.  But the code for the latter case
|    (in Missfields) looks for a header ending only in \n, and sets
|    the resulting string to include the \r\n.  The result: If you do a
|    rebuild of history without rebuilding overview (so the overview.fmt
|    never gets read, and all headers, including Message-ID, are in the
|    Missfields array), the Message-ID header string includes the trailing
|    \r\n, which causes GetMessageID to always declare the Message-ID to be
|    invalid.
|
|There are probably other bugs lurking in makehistory as well; with these fixes
|in place, a 'makehistory -b -u -v -n' ran to completion, and seemed to have
|approprately added a bunch of missing arts to history, but ever since I ran it,
|expire has been dumping core, so presumably there's some crud that got
|written into history. :-(.

END
